t3rmin4t0r commented on a change in pull request #853: HIVE-22463 decimal64 
multiplication
URL: https://github.com/apache/hive/pull/853#discussion_r350421423
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
 ##########
 @@ -1848,13 +1851,8 @@ private VectorExpression 
createDecimal64VectorExpression(Class<?> vectorClass,
       } else if (childExpr instanceof ExprNodeColumnDesc) {
         int colIndex = getInputColumnIndex((ExprNodeColumnDesc) childExpr);
         if (childrenMode == VectorExpressionDescriptor.Mode.FILTER) {
-
           VectorExpression filterExpr =
               getFilterOnBooleanColumnExpression((ExprNodeColumnDesc) 
childExpr, colIndex);
-          if (filterExpr == null) {
 
 Review comment:
   This needs to go back in

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to