pvary commented on a change in pull request #854: HIVE-22537: getAcidState()
not saving directory causes multiple files…
URL: https://github.com/apache/hive/pull/854#discussion_r350662374
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1728,23 +1755,15 @@ private static void getChildState(Path
candidateDirectory, List<HdfsDirSnapshot>
aborted.add(dirPath);
} else if (writeIdList.isWriteIdRangeValid(delta.minWriteId,
delta.maxWriteId) != ValidWriteIdList.RangeResponse.NONE) {
- if (delta.isRawFormat) {
- for (FileStatus stat : dirSnapshot.getFiles()) {
- if ((!ignoreEmptyFiles) || (stat.getLen() != 0)) {
- original.add(createOriginalObj(null, stat));
- }
- }
- } else {
- working.add(delta);
- }
+ working.add(delta);
}
} else {
if (!candidateDirectory.equals(dirPath)) {
Review comment:
Is this always true, because of the change above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
