maheshk114 commented on a change in pull request #883: HIVE-22736 Support
multiple encryption zones in replication
URL: https://github.com/apache/hive/pull/883#discussion_r370047831
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -461,12 +485,19 @@ static void scheduleCMClearer(Configuration conf) {
.namingPattern(CM_THREAD_NAME_PREFIX + "%d")
.daemon(true)
.build());
- executor.scheduleAtFixedRate(new CMClearer(MetastoreConf.getVar(conf,
ConfVars.REPLCMDIR),
- MetastoreConf.getTimeVar(conf, ConfVars.REPLCMRETIAN,
TimeUnit.SECONDS), conf),
- 0, MetastoreConf.getTimeVar(conf, ConfVars.REPLCMINTERVAL,
TimeUnit.SECONDS), TimeUnit.SECONDS);
+ for (Path cmroot : cmRootMapping.values()) {
Review comment:
The map is populated at run time..so at init time there may be no entry
added to the map. I think we should send the map to the scheduler and let it
iterate to cleanup the cm root for each EZ in the map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
