miklosgergely commented on a change in pull request #882: HIVE-22747 Break up 
DDLSemanticAnalyzer - extract Table info and lock analyzers
URL: https://github.com/apache/hive/pull/882#discussion_r377810208
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java
 ##########
 @@ -219,4 +220,21 @@ private static String getHS2Host(HiveConf conf) throws 
SemanticException {
 
     throw new SemanticException("Kill query is only supported in HiveServer2 
(not hive cli)");
   }
+
+  /**
+   * Get the fully qualified name in the node.
+   * E.g. the node of the form ^(DOT ^(DOT a b) c) will generate a name of the 
form "a.b.c".
+   */
+  public static String getFQName(ASTNode node) {
 
 Review comment:
   The original code for this was not removed yet, as it is still used by some 
other analyzers which are still in DDLSemanticAnalyzer, see the static class 
QualifiedNameUtil.  I don't see why wouldn't it work in quoted case, I guess 
the quotes are removed before building the ASTTree, isn't that the case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to