kgyrtkirk commented on a change in pull request #876: HIVE-22585: Clean up
catalog/db/table name usage
URL: https://github.com/apache/hive/pull/876#discussion_r381993869
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
##########
@@ -989,7 +990,7 @@ public void accept(NotificationEvent event) {
QueryResultsCache cache = QueryResultsCache.getInstance();
if (cache != null) {
long eventTime = event.getEventTime() * 1000L;
- cache.notifyTableChanged(dbName, tableName, eventTime);
+ cache.notifyTableChanged(TableName.fromString(tableName, null,
dbName), eventTime);
Review comment:
I wonder if it would make sense to leave out the category for now....it's
not really used - instead of passing null everywhere we could have a separate
method for (db,name)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
