kgyrtkirk commented on a change in pull request #897: HIVE-22824:
JoinProjectTranspose rule should skip Projects containing…
URL: https://github.com/apache/hive/pull/897#discussion_r383830139
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -487,7 +483,7 @@ Operator genOPTree(PlannerContext plannerCtx) throws
SemanticException {
ASTNode newAST = getOptimizedAST(newPlan);
// 1.1. Fix up the query for insert/ctas/materialized views
- newAST = fixUpAfterCbo(this.getAST(), newAST, cboCtx);
Review comment:
I don't see how this change will not reintroduce the issue fixed in
HIVE-22578
because the "fixUpAfterCbo" makes calls to a function named replaceASTChild
which changes the actual ast - and it may make it impossible to fallback to the
non-cbo path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
