aasha commented on a change in pull request #911: HIVE-22865 Include data in 
replication staging directory
URL: https://github.com/apache/hive/pull/911#discussion_r384345859
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -119,18 +121,19 @@ public String getName() {
   public int execute() {
     try {
       Hive hiveDb = getHive();
-      Path dumpRoot = new Path(conf.getVar(HiveConf.ConfVars.REPLDIR), 
getNextDumpDir());
-      DumpMetaData dmd = new DumpMetaData(dumpRoot, conf);
+      Path dumpBaseDir = new Path(conf.getVar(HiveConf.ConfVars.REPLDIR), 
getNextDumpDir());
+      Path hiveDumpRoot = new Path(dumpBaseDir, ReplUtils.REPL_HIVE_BASE_DIR);
+      DumpMetaData dmd = new DumpMetaData(hiveDumpRoot, conf);
       // Initialize ReplChangeManager instance since we will require it to 
encode file URI.
       ReplChangeManager.getInstance(conf);
       Path cmRoot = new Path(conf.getVar(HiveConf.ConfVars.REPLCMDIR));
       Long lastReplId;
       if (work.isBootStrapDump()) {
-        lastReplId = bootStrapDump(dumpRoot, dmd, cmRoot, hiveDb);
+        lastReplId = bootStrapDump(hiveDumpRoot, dmd, cmRoot, hiveDb);
 
 Review comment:
   Are we still keeping the cm?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to