cricket007 commented on a change in pull request #933: HIVE-21218: Adding support for Confluent Kafka Avro message format URL: https://github.com/apache/hive/pull/933#discussion_r387999324
########## File path: kafka-handler/src/test/org/apache/hadoop/hive/kafka/AvroBytesConverterTest.java ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.kafka; + +import com.google.common.collect.Maps; +import io.confluent.kafka.schemaregistry.client.MockSchemaRegistryClient; +import io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig; +import io.confluent.kafka.serializers.KafkaAvroSerializer; +import org.apache.avro.Schema; +import org.apache.hadoop.hive.serde2.avro.AvroGenericRecordWritable; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.util.Arrays; +import java.util.Map; + +/** + * Test class for Hive Kafka Avro bytes converter. + */ +public class AvroBytesConverterTest { + private static SimpleRecord simpleRecord1 = SimpleRecord.newBuilder().setId("123").setName("test").build(); + private static byte[] simpleRecord1AsBytes; + + /** + * Emulate confluent avro producer that add 4 magic bits (int) before value bytes. The int represents the schema ID from schema registry. + */ + @BeforeClass + public static void setUp() { + Map<String, String> config = Maps.newHashMap(); + config.put(AbstractKafkaAvroSerDeConfig.SCHEMA_REGISTRY_URL_CONFIG, "http://localhost:8081";); + KafkaAvroSerializer avroSerializer = new KafkaAvroSerializer(new MockSchemaRegistryClient()); + avroSerializer.configure(config, false); + simpleRecord1AsBytes = avroSerializer.serialize("temp", simpleRecord1); + } + + /** + * Emulate - avro.serde.type = none (Default). + */ + @Test + public void convertWithAvroBytesConverter() { + Schema schema = SimpleRecord.getClassSchema(); + KafkaSerDe.AvroBytesConverter conv = new KafkaSerDe.AvroBytesConverter(schema); + AvroGenericRecordWritable simpleRecord1Writable = conv.getWritable(simpleRecord1AsBytes); + + Assert.assertNotNull(simpleRecord1Writable); + Assert.assertEquals(SimpleRecord.class, simpleRecord1Writable.getRecord().getClass()); + + SimpleRecord simpleRecord1Deserialized = (SimpleRecord) simpleRecord1Writable.getRecord(); + + Assert.assertNotNull(simpleRecord1Deserialized); + Assert.assertNotEquals(simpleRecord1, simpleRecord1Deserialized); + } + + /** + * Emulate - avro.serde.type = confluent. + */ + @Test + public void convertWithConfluentAvroBytesConverter() { + Schema schema = SimpleRecord.getClassSchema(); + KafkaSerDe.AvroSkipBytesConverter conv = new KafkaSerDe.AvroSkipBytesConverter(schema, 5); + AvroGenericRecordWritable simpleRecord1Writable = conv.getWritable(simpleRecord1AsBytes); + + Assert.assertNotNull(simpleRecord1Writable); + Assert.assertEquals(SimpleRecord.class, simpleRecord1Writable.getRecord().getClass()); + + SimpleRecord simpleRecord1Deserialized = (SimpleRecord) simpleRecord1Writable.getRecord(); + + Assert.assertNotNull(simpleRecord1Deserialized); + Assert.assertEquals(simpleRecord1, simpleRecord1Deserialized); Review comment: What does the `1` represent here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
