davidov541 commented on a change in pull request #933: HIVE-21218: Adding
support for Confluent Kafka Avro message format
URL: https://github.com/apache/hive/pull/933#discussion_r388540929
##########
File path: kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaSerDe.java
##########
@@ -133,12 +134,44 @@
Preconditions.checkArgument(!schemaFromProperty.isEmpty(), "Avro Schema
is empty Can not go further");
Schema schema = AvroSerdeUtils.getSchemaFor(schemaFromProperty);
LOG.debug("Building Avro Reader with schema {}", schemaFromProperty);
- bytesConverter = new AvroBytesConverter(schema);
+ bytesConverter = getByteConverterForAvroDelegate(schema, tbl);
} else {
bytesConverter = new BytesWritableConverter();
}
}
+ enum BytesConverterType {
+ SKIP,
+ NONE;
+
+ static BytesConverterType fromString(String value) {
+ try {
+ return BytesConverterType.valueOf(value.trim().toUpperCase());
+ } catch (Exception e){
+ return NONE;
+ }
+ }
+ }
+
+ BytesConverter getByteConverterForAvroDelegate(Schema schema, Properties
tbl) throws SerDeException {
+ String avroBytesConverterPropertyName =
AvroSerdeUtils.AvroTableProperties.AVRO_SERDE_TYPE.getPropName();
+ String avroBytesConverterProperty =
tbl.getProperty(avroBytesConverterPropertyName,
+ BytesConverterType.NONE.toString());
+ BytesConverterType avroByteConverterType =
BytesConverterType.fromString(avroBytesConverterProperty);
+ String avroSkipBytesPropertyName =
AvroSerdeUtils.AvroTableProperties.AVRO_SERDE_SKIP_BYTES.getPropName();
+ Integer avroSkipBytes = 0;
+ try {
+ Integer.parseInt(tbl.getProperty(avroSkipBytesPropertyName));
Review comment:
Dangit, you're right. I'll fix this and get a test for this too, since we
should be catching these sorts of things in tests. I've got an old build around
here of a Hive test cluster. I'll see if I can bring that up and give it a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
