jcamachor commented on a change in pull request #941: HIVE-22979: Support total
file size in statistics annotation
URL: https://github.com/apache/hive/pull/941#discussion_r389043859
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java
##########
@@ -53,19 +53,21 @@ public State merge(State otherState) {
private long numRows;
private long runTimeNumRows;
private long dataSize;
+ private long totalFileSize;
Review comment:
Could you add a comment on what dataSize and totalFileSize mean? It will
prevent us from getting confused when we check the code back after some time :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
