vineetgarg02 commented on a change in pull request #938: HIVE-22978 URL: https://github.com/apache/hive/pull/938#discussion_r389846825
########## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java ########## @@ -37,6 +39,14 @@ private static final int MAX_BINARY_PRECISION = Integer.MAX_VALUE; private static final int MAX_TIMESTAMP_PRECISION = 9; private static final int MAX_TIMESTAMP_WITH_LOCAL_TIME_ZONE_PRECISION = 15; // Up to nanos + private static final int DEFAULT_BOOLEAN_PRECISION = 1; Review comment: What does BOOLEAN with precision 1 mean? I thought precision only pertain to numeric data type. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
