maheshk114 commented on a change in pull request #949: HIVE-22990 Add file
based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r392037888
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -3262,14 +3286,11 @@ public void testDumpNonReplDatabase() throws
IOException {
verifyFail("REPL DUMP " + dbName, driver);
assertTrue(run("REPL DUMP " + dbName + " with
('hive.repl.dump.metadata.only' = 'true')",
true, driver));
+ //Dump again before load will print a warning
assertTrue(run("REPL DUMP " + dbName + " with
('hive.repl.dump.metadata.only' = 'true')",
true, driver));
- run("alter database " + dbName + " set dbproperties ('repl.source.for' =
'1, 2, 3')", driver);
- assertTrue(run("REPL DUMP " + dbName, true, driver));
Review comment:
so many changes in existing test cases should be avoided
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
