odraese commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r395925728
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
##########
@@ -138,7 +137,7 @@ public void notifyLock(LlapCacheableBuffer buffer) {
// a locked item in either, it will remove it from cache; when we unlock,
we are going to
// put it back or update it, depending on whether this has happened. This
should cause
// most of the expensive cache update work to happen in unlock, not
blocking processing.
- if (buffer.indexInHeap != LlapCacheableBuffer.IN_LIST ||
!listLock.tryLock()) {
+ if (buffer.cacheAttribute == null || buffer.cacheAttribute.getIndex() !=
IN_LIST || !listLock.tryLock()) {
Review comment:
Question: what scenario can lead to a null cacheAttribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
