pgaref commented on a change in pull request #952: HIVE-23006 ProbeDecode
compiler support
URL: https://github.com/apache/hive/pull/952#discussion_r404318170
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
##########
@@ -1483,17 +1489,64 @@ private void
removeSemijoinsParallelToMapJoin(OptimizeTezProcContext procCtx)
}
}
- if (semijoins.size() > 0) {
- for (ReduceSinkOperator rs : semijoins.keySet()) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Semijoin optimization with parallel edge to map join.
Removing semijoin "
- + OperatorUtils.getOpNamePretty(rs) + " - " +
OperatorUtils.getOpNamePretty(semijoins.get(rs)));
+ if
(!procCtx.conf.getBoolVar(ConfVars.TEZ_DYNAMIC_SEMIJOIN_REDUCTION_FOR_MAPJOIN))
{
+ if (semijoins.size() > 0) {
Review comment:
Hey @jcamachor -- in this case I just followed the logic
[above](https://github.com/apache/hive/pull/952/files#diff-228178321e4c1df7f045fe181de2fffaL1450)
where we seems to bail-out when
TEZ_DYNAMIC_SEMIJOIN_REDUCTION_FOR_MAPJOIN is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
