omalley commented on a change in pull request #983: HIVE-23215. Make
FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409648595
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
##########
@@ -338,6 +339,7 @@ public void write(DataOutput arg0) throws IOException {
* - resets each column
* - inits each column
*/
+ @Override
public void reset() {
Review comment:
My problem is that VectorizedRowBatch currently has an implicit invariant
that selected is never null. Changing that assumption seems potentially
problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
