omalley commented on issue #983: URL: https://github.com/apache/hive/pull/983#issuecomment-616722525
This seems to work well when I was working with the filters for ORC-577. A couple of comments: * It feels a little worrisome letting the user pass in a selection array and they never know the right length without calling getSelectionSize first. * We probably don't need the separate setSelectedInUser and setSelectedSize. All of the filters would just call setFilterContext to set both in a single call. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
