jcamachor commented on a change in pull request #988:
URL: https://github.com/apache/hive/pull/988#discussion_r414669324
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -1967,6 +1968,13 @@ private RelNode applyPreJoinOrderingTransforms(RelNode
basePlan, RelMetadataProv
generatePartialProgram(program, false, HepMatchOrder.DEPTH_FIRST,
HiveExceptRewriteRule.INSTANCE);
+ // ?
Review comment:
Good point.
I am not sure the decorrelation logic or any rule executed before this one
would introduce a `count distinct` or any of the other functions that we will
be targeting.
However, if that would be the case at some point, probably we do not want to
be mangling with them in our new rules.
Thus, executing it as the very first step, even before decorrelation, would
make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
