pgaref commented on a change in pull request #998:
URL: https://github.com/apache/hive/pull/998#discussion_r417300530
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java
##########
@@ -1633,16 +1638,20 @@ private ObjectInspector getOiFromSerDe() throws
IOException {
}
}
- private ReaderWithOffsets createOffsetReader(RecordReader<?, ?>
sourceReader) {
+ private ReaderWithOffsets createOffsetReader(RecordReader<?, ?>
sourceReader, TableDesc tableDesc)
+ throws IOException {
+ int headerCount = Utilities.getHeaderCount(tableDesc);
+ int footerCount = Utilities.getFooterCount(tableDesc, jobConf);
if (LlapIoImpl.LOG.isDebugEnabled()) {
- LlapIoImpl.LOG.debug("Using " + sourceReader.getClass().getSimpleName()
+ " to read data");
+ LlapIoImpl.LOG.debug("Using {} to read data with HeaderSkip {} and
FooterSkip {}",
Review comment:
sure, will use table settings names instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
