jcamachor commented on a change in pull request #1034:
URL: https://github.com/apache/hive/pull/1034#discussion_r432188236
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java
##########
@@ -127,15 +131,16 @@ public int process(Hive db, Table tbl) throws Exception {
LOG.debug("Because {} is infinite or NaN, we skip stats.",
columnName, e);
}
}
+ pos += columnStatsFields.size();
Review comment:
I want to circle back on this. Finally I had to undo this change since
the exception above breaks the flow and you need to know the position in the
outer method, it is not sufficient to rely on the iterator. I think the
workflow could be slightly different if the exception would be caught in the
internal methods; maybe worth tackling at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
