pkumarsinha commented on a change in pull request #1040:
URL: https://github.com/apache/hive/pull/1040#discussion_r432585845



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -73,7 +74,12 @@ public int execute() {
       String entityGuid = checkHiveEntityGuid(atlasRequestBuilder, 
atlasReplInfo.getSrcCluster(),
               atlasReplInfo.getSrcDB());
       long currentModifiedTime = getCurrentTimestamp(atlasReplInfo, 
entityGuid);
-      dumpAtlasMetaData(atlasRequestBuilder, atlasReplInfo);
+      AtlasDumpLogger replLogger = new 
AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+              atlasReplInfo.getStagingDir().toString());
+      replLogger.startLog();
+      long numBytesWritten = dumpAtlasMetaData(atlasRequestBuilder, 
atlasReplInfo);
+      LOG.debug("Finished dumping atlas metadata, total:{} bytes written", 
numBytesWritten);
+      replLogger.endLog(0L);

Review comment:
       We don't need this return value. This is just a workaround for the 
mockito bug where it is calling a method of a mocked object. Like the one we 
had seen during atlas repl initial patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to