belugabehr commented on a change in pull request #947:
URL: https://github.com/apache/hive/pull/947#discussion_r434641680
##########
File path: .travis.yml
##########
@@ -42,4 +42,4 @@ before_install:
install: true
-script: travis_wait 30 mvn clean install -DskipTests -T 4 -q -Pitests
+script: mvn clean install -DskipTests -q -Pitests
Review comment:
Not related to this task. Please remove.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
##########
@@ -310,7 +311,11 @@ protected void openInternal(final HiveConf conf,
Collection<String> additionalFi
setupSessionAcls(tezConfig, conf);
- final TezClient session = TezClient.newBuilder("HIVE-" + sessionId,
tezConfig)
+ String tezJobName = HiveConf.getVar(conf,ConfVars.HIVETEZJOBNAME);
+ if (StringUtils.isBlank(tezJobName)){
+ tezJobName = "HIVE-" + sessionId;
Review comment:
What is the value of setting a hard coded name here?
I think it would be more useful if it would accept a Format String:
`
tezJobName = String.format("HIVE-%s", sessionId);
`
The default value of the configuration should be `HIVE-%s`
##########
File path: .travis.yml
##########
@@ -33,7 +33,7 @@ cache:
env:
MAVEN_SKIP_RC=true
- MAVEN_OPTS="-Xmx2g -XX:MaxPermSize=512M"
Review comment:
Not related to this task. Please remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
