dengzhhu653 commented on pull request #1029: URL: https://github.com/apache/hive/pull/1029#issuecomment-638728373
> I think the best thing would be to modify this: > > https://github.com/apache/hive/blob/2795d3253f5ff09c23b12e5ff980cb14268d37ab/jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java#L189-L202 > > Thrift does not have sub-classes for Exception, but Exceptions generally carry a type. In this case, the type is `TApplicationException.BAD_SEQUENCE_ID` : > > https://github.com/apache/thrift/blob/af7ecd6a2b15efe5c6b742cf4a9ccb31bcc1f362/lib/java/src/org/apache/thrift/TServiceClient.java#L84-L87 > > I think the best course of action here is to catch the Exception in the `HiveStatement`, check the 'type', and if it is `BAD_SEQUENCE_ID`, wrap the Exception in a `SQLException` and provide a better error message that is more clear. > > That `Commands` method is a bit hairy, but all that needs to happen as a quick fix is to wrap the `Statement#close()` with its own try-catch block. There is no need to close the result set. Closing the Statement should close all associated result sets. > > > When a Statement object is closed, its current ResultSet object, if one exists, is also closed. > > https://docs.oracle.com/javase/7/docs/api/java/sql/Statement.html#close() Updated, wrap the exception with some messages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
