pgaref commented on pull request #1069: URL: https://github.com/apache/hive/pull/1069#issuecomment-640113437
> @pgaref The violations are available in pipeline logs. I have mixed feelings about pushing back the results to associated Jira or to the PR. Previously these reports were in the form of warning. It makes sense to push it back to JIra then, so people see them before merging changes. Now, you cannot even get a test run without succeeding the report. So if you have a green test run, you know that you did not introduce a new violation. If the pipeline fails because of a new violation, it is easy enough to see the violations in pipeline logs. Also the report becomes stale as soon as you push new changes. Personally, I really dont like the clutter stale reports create on Jiras. Anyway, I think it is more important to introduce this check as soon as possible. Reporting back can be introduced later if people really miss it. Agreed, lets introduce the check asap -- failing would also save us testing resources as discussed. Reporting can be done as a second step. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
