aasha commented on a change in pull request #1044: URL: https://github.com/apache/hive/pull/1044#discussion_r436448726
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.ql.parse.repl.metric; + +import org.apache.hadoop.hive.conf.Constants; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.utils.StringUtils; +import org.apache.hadoop.hive.ql.parse.SemanticException; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.ReplicationMetric; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.Metadata; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.Progress; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.Stage; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.Status; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.Metric; + +import java.util.Map; + +/** + * Abstract class for Replication Metric Collection. + */ +public abstract class ReplicationMetricCollector { + private ReplicationMetric replicationMetric; + private MetricCollector metricCollector; + private boolean isEnabled; + + public ReplicationMetricCollector(String dbName, Metadata.ReplicationType replicationType, + String stagingDir, long dumpExecutionId, HiveConf conf) { + String policy = conf.get(Constants.SCHEDULED_QUERY_SCHEDULENAME); + long executionId = conf.getLong(Constants.SCHEDULED_QUERY_EXECUTIONID, 0L); + if (!StringUtils.isEmpty(policy) && executionId > 0) { Review comment: Its not optional feature. These configs are internal to hive scheduler. If any replication is triggered by the scheduler, these will always be present. If some client calls the commands directly like DAS, metrics will not be present. Lets not add unnecesary configs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
