pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r439069045
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
##########
@@ -118,4 +118,19 @@
* @return smallest Open write Id in this set, {@code null} if there is none.
*/
Long getMinOpenWriteId();
+
+ /**
+ * Mark the writeId as locally committed within the Hive Metastore client.
+ * This will not mark a given writeId as committed on the server.
+ * This is required for transactional managed tables, especially for cases
in which a
+ * given statement results in a write followed by a read.
+ * Although right now the transactional boundary is a statement, there can
be single statements
+ * that can result in a write followed by a write.
+ * For example: Create Table As Select (CTAS) and Dynamic-Partition Insert
+ * Marking the writeId of the previous write within the same session as
committed would
+ * ensure that the subsequent read will invalidate the cache entry. This
behavior is essential when
+ * we want to provide cache consistency with HMS HA.
+ * @param writeId
+ */
+ void locallyCommitWriteId(long writeId);
Review comment:
Again optimization specific
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
