pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r439266853
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java
##########
@@ -188,9 +189,11 @@ public int persistColumnStats(Hive db, Table tbl) throws
HiveException, MetaExce
HiveTxnManager txnMgr = AcidUtils.isTransactionalTable(tbl)
? SessionState.get().getTxnMgr() : null;
if (txnMgr != null) {
- request.setValidWriteIdList(AcidUtils.getTableValidWriteIdList(conf,
- AcidUtils.getFullTableName(tbl.getDbName(),
tbl.getTableName())).toString());
request.setWriteId(txnMgr.getAllocatedTableWriteId(tbl.getDbName(),
tbl.getTableName()));
+ ValidWriteIdList writeId = AcidUtils.getTableValidWriteIdList(conf,
+ AcidUtils.getFullTableName(tbl.getDbName(), tbl.getTableName()));
+ writeId.locallyCommitWriteId(request.getWriteId());
Review comment:
Ok.. I think this is what I do not get.
What is CachedStore or CatalogD in this context. Where it is running? HS2
side? HMS side? What is the responsibility of it? Any docs, so I can learn?
Thanks,
Peter
Also, strictly speaking this is still not transactional. Either we accept
that writeId generation for DDL is non-immediate, or we do it in the same
transaction. Otherwise we just dig the problems deeper. Am I mistaken somewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
