klcopp commented on pull request #1085: URL: https://github.com/apache/hive/pull/1085#issuecomment-643168765
@rajkrrsingh Thanks for creating the test case! [the isEnoughToCompact check will not mark it clean if there are obsolete directories. markCompacted puts it into "ready for cleaning" state](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java#L501-L507) I think taking this route is much simpler and less error-prone than expanding the TxnHandler API. If you take it, you'll need to add startWorker() to the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
