pkumarsinha commented on a change in pull request #1110:
URL: https://github.com/apache/hive/pull/1110#discussion_r441353012
##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -1534,10 +1534,10 @@
<column name="RM_DUMP_EXECUTION_ID" jdbc-type="bigint"
allows-null="false"/>
</field>
<field name="metadata">
- <column name="RM_METADATA" jdbc-type="varchar" allows-null="true"/>
+ <column name="RM_METADATA" jdbc-type="varchar" length="4000"
allows-null="true"/>
Review comment:
In case when it has just added the entry with null value for metadata
and progress and sink happens,
Shouldn't this create problem while serializing metadata and progress in
MetricSink.java
persistentMetric.setProgress(mapper.writeValueAsString(metric.getProgress()));
persistentMetric.setMetadata(mapper.writeValueAsString(metric.getMetadata()));
i.e is json serialization and deserialization fine in that case(values being
null)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
