pkumarsinha commented on a change in pull request #1129:
URL: https://github.com/apache/hive/pull/1129#discussion_r441356936
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -981,9 +981,15 @@ public static ConfVars getMetaConf(String name) {
+ " and the frequency of persisting the metrics to persistent storage.
"
),
REPL_METRICS_UPDATE_FREQUENCY("metastore.repl.metrics.update.frequency",
- "hive.repl.metrics.update.frequency", 1 /*1 minute */,
+ "hive.repl.metrics.update.frequency", 1, TimeUnit.MINUTES /*1 minute */,
"Frequency at which replication Metrics will be stored in persistent
storage. "
),
+ REPL_METRICS_CLEANUP_FREQUENCY("metastore.repl.metrics.cleanup.frequency",
Review comment:
This case is fine, but say customer set the REPL_METRICS_MAX_AGE as 5
days and REPL_METRICS_CLEANUP_FREQUENCY as 30 days, this will lead to
confusion. REPL_METRICS_MAX_AGE is also considered and crucial to decide how
much data we would end up storing at a given time and REPL_METRICS_MAX_AGE is
ideally to control that. The REPL_METRICS_CLEANUP_FREQUENCY here is more
influential than the REPL_METRICS_MAX_AGE which shouldn't be the case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
