pvary commented on a change in pull request #1067: URL: https://github.com/apache/hive/pull/1067#discussion_r441373486
########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java ########## @@ -899,12 +873,8 @@ private boolean shouldBeFlushed(KeyWrapper newKeys) { // Assuming the used memory is equally divided among all executors. usedMemory = isLlap ? usedMemory / numExecutors : usedMemory; rate = (float) usedMemory / (float) maxMemory; - if(rate > memoryThreshold){ - if (isTez && numEntriesHashTable == 0) { - return false; - } else { - return true; - } + if (rate > memoryThreshold){ Review comment: nit: missing space ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org