pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r442740328



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/skewed/AlterTableNotSkewedDesc.java
##########
@@ -38,6 +38,6 @@ public AlterTableNotSkewedDesc(TableName tableName) throws 
SemanticException {
 
   @Override
   public boolean mayNeedWriteId() {
-    return false;
+    return true;

Review comment:
       AFAIK we do not support skewed ACID tables

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/skewed/AlterTableSetSkewedLocationDesc.java
##########
@@ -57,6 +57,6 @@ public AlterTableSetSkewedLocationDesc(TableName tableName, 
Map<String, String>
 
   @Override
   public boolean mayNeedWriteId() {
-    return false;
+    return true;

Review comment:
       AFAIK we do not support skewed ACID tables




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to