kishendas commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r443051632
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -366,13 +367,22 @@ private void acquireLocks() throws
CommandProcessorException {
driverContext.getTxnManager().getTableWriteId(t.getDbName(),
t.getTableName());
}
-
DDLDescWithWriteId acidDdlDesc =
driverContext.getPlan().getAcidDdlDesc();
boolean hasAcidDdl = acidDdlDesc != null && acidDdlDesc.mayNeedWriteId();
Review comment:
Thats more of a refactoring and not sure how it would affect the test
cases. I don't want to refactor it as part of this patch, as it's already big
and hundreds of test cases are failing. However, I created a JIRA for the same
-> https://issues.apache.org/jira/browse/HIVE-23732 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
