kishendas commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r443062664
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -875,6 +888,7 @@ public void alterPartition(String tblName, Partition
newPart,
public void alterPartition(String catName, String dbName, String tblName,
Partition newPart,
EnvironmentContext environmentContext, boolean
transactional)
throws InvalidOperationException, HiveException {
+
Review comment:
Rebased with master and only kept relevant changes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -997,8 +1017,9 @@ public void renamePartition(Table tbl, Map<String, String>
oldPartSpec, Partitio
}
String validWriteIds = null;
if (AcidUtils.isTransactionalTable(tbl)) {
+
TableSnapshot tableSnapshot;
- if (replWriteId > 0) {
+ if (inReplication(tbl)) {
Review comment:
Rebased with master and only kept relevant changes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -1230,14 +1255,22 @@ public void dropTable(String dbName, String tableName,
boolean deleteData,
*/
public void dropTable(String dbName, String tableName, boolean deleteData,
boolean ignoreUnknownTab, boolean ifPurge) throws HiveException {
+
try {
+ Table tbl = null;
+ try {
+ tbl = getTable(dbName, tableName);
+ } catch (InvalidTableException e) {
+ }
+
Review comment:
Rebased with master and only kept relevant changes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -5560,12 +5604,16 @@ public void cacheFileMetadata(
public void dropConstraint(String dbName, String tableName, String
constraintName)
throws HiveException, NoSuchObjectException {
+
try {
+ Table tbl = getTable(dbName, tableName);
+
Review comment:
Rebased with master and only kept relevant changes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -5892,54 +5940,73 @@ public CheckConstraint getCheckConstraints(String
dbName, String tblName)
public void addPrimaryKey(List<SQLPrimaryKey> primaryKeyCols)
throws HiveException, NoSuchObjectException {
try {
+ Table tbl = getTable(primaryKeyCols.get(0).getTable_db(),
primaryKeyCols.get(0).getTable_name());
+
Review comment:
Rebased with master and only kept relevant changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
