deniskuzZ commented on a change in pull request #1151:
URL: https://github.com/apache/hive/pull/1151#discussion_r444691595
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/reexec/ReOptimizePlugin.java
##########
@@ -80,14 +83,15 @@ public void initialize(Driver driver) {
coreDriver.getHookRunner().addOnFailureHook(statsReaderHook);
coreDriver.getHookRunner().addPostHook(statsReaderHook);
alwaysCollectStats =
driver.getConf().getBoolVar(ConfVars.HIVE_QUERY_REEXECUTION_ALWAYS_COLLECT_OPERATOR_STATS);
+ maxExecutions = 1 +
coreDriver.getConf().getIntVar(ConfVars.HIVE_QUERY_MAX_REEXECUTION_COUNT);
Review comment:
could we move this under IReExecutionPlugin default method? and override
shouldReExecute when needed?
i think (executionNum < maxExecutions) check is a generic one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
