asinkovits commented on a change in pull request #1159:
URL: https://github.com/apache/hive/pull/1159#discussion_r445619133
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java
##########
@@ -305,10 +305,10 @@ private boolean lockBuffer(LlapDataBuffer buffer, boolean
doNotifyPolicy) {
long offset = ranges[i].getOffset() + baseOffset;
assert buffer.declaredCachedLength ==
LlapDataBuffer.UNKNOWN_CACHED_LENGTH;
buffer.declaredCachedLength = ranges[i].getLength();
- buffer.setTag(tag);
while (true) { // Overwhelmingly executes once, or maybe twice
(replacing stale value).
LlapDataBuffer oldVal = subCache.getCache().putIfAbsent(offset,
buffer);
if (oldVal == null) {
+ buffer.setFileCache(subCache);
Review comment:
Thanks, it's fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
