deniskuzZ commented on a change in pull request #1087:
URL: https://github.com/apache/hive/pull/1087#discussion_r446131988
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java
##########
@@ -2209,20 +2209,7 @@ public void testAcidOrcWritePreservesFieldNames() throws
Exception {
* sorts rows in dictionary order
*/
static List<String> stringifyValues(int[][] rowsIn) {
- assert rowsIn.length > 0;
- int[][] rows = rowsIn.clone();
- Arrays.sort(rows, new RowComp());
- List<String> rs = new ArrayList<String>();
- for(int[] row : rows) {
- assert row.length > 0;
- StringBuilder sb = new StringBuilder();
- for(int value : row) {
- sb.append(value).append("\t");
- }
- sb.setLength(sb.length() - 1);
- rs.add(sb.toString());
- }
- return rs;
+ return TxnCommandsBaseForTests.stringifyValues(rowsIn);
Review comment:
could you extend TestTxnCommands2 from TxnCommandsBaseForTests and
remove static?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
