jcamachor commented on a change in pull request #1177:
URL: https://github.com/apache/hive/pull/1177#discussion_r446323133



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java
##########
@@ -142,6 +143,19 @@ public PTFDesc translate(WindowingSpec wdwSpec, 
SemanticAnalyzer semAly, HiveCon
       UnparseTranslator unparseT)
       throws SemanticException {
     init(semAly, hCfg, inputRR, unparseT);
+    for (int i = 0; i < wdwSpec.getWindowExpressions().size(); ++i) {

Review comment:
       Should we do this rewriting via Calcite rule instead of adding this 
custom logic over here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to