pkumarsinha commented on a change in pull request #1173:
URL: https://github.com/apache/hive/pull/1173#discussion_r446802228



##########
File path: 
ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestRangerLoadTask.java
##########
@@ -263,4 +267,56 @@ public void testSuccessDisableDenyRangerPolicies() throws 
Exception {
     //Deny policy is added
     Assert.assertEquals(1, actualPolicyList.getListSize());
   }
+
+  @Test
+  public void testRangerEndpointCreation() throws Exception {
+    URIBuilder uriBuilder = new URIBuilder("http://ranger.apache.org:6080";);

Review comment:
       It tests actually URIBuilder, and not the testRanger endpoint creation 
flow. It would have been good if we could have had this test in 
RangerRestClient level. Otherwise the change looks to me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to