pvary commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r450753988
########## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ########## @@ -3284,6 +3299,8 @@ public Partition getPartition(Table tbl, Map<String, String> partSpec, } org.apache.hadoop.hive.metastore.api.Partition tpart = null; try { + // TODO: Either create a new getPartitionWithAuthInfo API with request/response format that takes + // ValidWriteIdList and tableId or if this API is no longer required, remove all the references. Review comment: We are aiming to be backwards compatible. Removing an API method should not be a real option. It might be ok, to return a failure for transactional tables. What was our solution for the new API in the other cases? @nrg4878 might have more ideas for this case ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org