pvargacl commented on a change in pull request #1219:
URL: https://github.com/apache/hive/pull/1219#discussion_r450829187



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -568,6 +568,7 @@ public OpenTxnsResponse openTxns(OpenTxnRequest rqst) 
throws MetaException {
            */
           LOG.error("OpenTxnTimeOut exceeded commit duration {}, deleting 
transactionIds: {}", elapsedMillis, txnIds);
           deleteInvalidOpenTransactions(dbConn, txnIds);
+          dbConn.commit();

Review comment:
       It was missing, the delete was not persisted. When I was testing 
manually, I didn't notice, because I was querying back the data on the same 
connection...
   It does not cause a big problem, these transactions would be cleaned up 
eventually when they time out.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to