kgyrtkirk commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-656010567
Hey @dengzhhu653 this comment might have not caught your attention: > I don't think this is a move in the right direction; you are moving the `HS2::stop` out into an "optional" hook stuff...which could be just removed by a conf change - I think it should remain part of the system. > > ...your objective seems to be to add diagnostic capabilities around when the OOM happens; I think in case you get an oom the best is to capture a heapdump...and analyze that: to see what's wrong > but I may not know all the details... > > I think creating some generic hook stuff which also gets notified about OOM - would be a better option what do you think about creating some more generic hook stuff (and add - and then we can tie that in into more places if needed...if we put OOM in the name of things we may not re-use it later I've noticed one more thing: do we really need to put the `HS2` instance into the hookcontext? I don't think we wan't to guarantee that the interface of that class will not change...and as such: it should not be placed in a context accesible by extensions ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
