pvary commented on a change in pull request #1235:
URL: https://github.com/apache/hive/pull/1235#discussion_r452677923
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java
##########
@@ -553,11 +553,13 @@ private void release(boolean releaseLocks) {
LOG.warn("Exception when releasing locking in destroy: " +
e.getMessage());
}
}
- ShutdownHookManager.removeShutdownHook(shutdownRunner);
+ ShutdownHookManager.removeShutdownHook(txnRollbackRunner);
}
void releaseLocksAndCommitOrRollback(boolean commit) throws LockException {
Review comment:
After some more thought, I still was not able to come up with a really
good idea :(
The best I can think is that we should rename the method to
_commitAndCleanUp_
But I still open for any other ideas if you have some.
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
