pvary commented on a change in pull request #1256:
URL: https://github.com/apache/hive/pull/1256#discussion_r455213413
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -4206,6 +4206,10 @@ private static void copyFiles(final HiveConf conf, final
FileSystem destFs,
}
}
files = fileStatuses.toArray(new FileStatus[files.length]);
+
+ if (HiveConf.getBoolVar(conf,
HiveConf.ConfVars.HIVE_WRITE_ACID_VERSION_FILE)) {
+ AcidUtils.OrcAcidVersion.writeVersionFile(destf, destFs);
+ }
Review comment:
It was a my first try to have it in the FSOperator which I have forgot
to remove. After FSO we have like 3 moves which I wanted to avoid, so since we
already have a Compactor specific change in copyFiles, I have decided to reuse
it
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -25,9 +25,11 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
+import java.util.HashSet;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
