deniskuzZ commented on a change in pull request #1244:
URL: https://github.com/apache/hive/pull/1244#discussion_r455711296



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/MergeJoinWork.java
##########
@@ -66,6 +67,13 @@ public void replaceRoots(Map<Operator<?>, Operator<?>> 
replacementMap) {
 
   @Override
   public void configureJobConf(JobConf job) {

Review comment:
       I think, it can be extracted to base. In MapWork and ReduceWork , for 
example, you can do same, at least for FileSinkOperator - iterate over 
getAllRootOperators() and call configureJobConf




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to