pgaref commented on a change in pull request #1273: URL: https://github.com/apache/hive/pull/1273#discussion_r456603816
########## File path: ql/src/test/queries/clientpositive/load_micromanaged_delim.q ########## @@ -0,0 +1,32 @@ +set hive.support.concurrency=true; +set hive.exec.dynamic.partition.mode=nonstrict; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; + + +dfs -mkdir ${system:test.tmp.dir}/delim_table; +dfs -mkdir ${system:test.tmp.dir}/delim_table_ext; +dfs -mkdir ${system:test.tmp.dir}/delim_table_trans; +dfs -cp ${system:hive.root}/data/files/table1 ${system:test.tmp.dir}/delim_table/; +dfs -cp ${system:hive.root}/data/files/table1 ${system:test.tmp.dir}/delim_table_ext/; +dfs -cp ${system:hive.root}/data/files/table1 ${system:test.tmp.dir}/delim_table_trans/; + +-- Checking that MicroManged and External tables have the same behaviour with delimited input files +-- External table +CREATE EXTERNAL TABLE delim_table_ext(id INT, name STRING, safety INT) ROW FORMAT DELIMITED FIELDS TERMINATED BY '\t' STORED AS TEXTFILE LOCATION '${system:test.tmp.dir}/delim_table_ext/'; +describe formatted delim_table_ext; +SELECT * FROM delim_table_ext; + +-- SET hive.create.as.acid=true +-- SET hive.create.as.insert.only=true Review comment: Creates the same behaviour as the Table properties below but I agree it makes sense to remove it ########## File path: data/files/table1 ########## @@ -0,0 +1,5 @@ +1 Acura 4 Review comment: sure, done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org