pvary commented on a change in pull request #1232:
URL: https://github.com/apache/hive/pull/1232#discussion_r457220034
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2066,6 +2066,10 @@ struct GetReplicationMetricsRequest {
3: optional i64 dumpExecutionId
}
+struct GetOpenTxnsRequest {
+ 1: required list<TxnType> excludeTxnTypes;
Review comment:
Could we make this optional? So if we later want to change the
GetOpenTxnsRequest object we do not end up sending an empty list all the time?
(as a general rule for new methods we create a Request object for them with all
optional fields)
Also this might need some checks later in the code, but we might want to
merge the codepath for the original get_open_txns method with this new one as
soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
