pvary commented on a change in pull request #1275:
URL: https://github.com/apache/hive/pull/1275#discussion_r458027913
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -64,13 +67,15 @@
static final private String CLASS_NAME = Cleaner.class.getName();
static final private Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
private long cleanerCheckInterval = 0;
+ private Executor cleanerExecutor;
private ReplChangeManager replChangeManager;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
replChangeManager = ReplChangeManager.getInstance(conf);
+ cleanerExecutor =
Executors.newFixedThreadPool(conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_REQUEST_QUEUE));
Review comment:
I prefer the way how it was done in Worker.java:
- Named threads
- Priority down
- Set daemon on/off
- Stopped in finally
Shall we do it here, or should we create a follow-up jira for creating and
cleaning up the executor threads for Cleaner and Initiator as well?
Thanks,
Peter
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -64,13 +67,15 @@
static final private String CLASS_NAME = Cleaner.class.getName();
static final private Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
private long cleanerCheckInterval = 0;
+ private Executor cleanerExecutor;
private ReplChangeManager replChangeManager;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
replChangeManager = ReplChangeManager.getInstance(conf);
+ cleanerExecutor =
Executors.newFixedThreadPool(conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_REQUEST_QUEUE));
Review comment:
I prefer the way how it was done in Worker.java:
- Named threads
- Priority down
- Set daemon on/off
- Stopped in finally
Shall we do it here, or should we create a follow-up jira for creating and
cleaning up the executor threads for Cleaner and Initiator as well?
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
