deniskuzZ commented on a change in pull request #1275:
URL: https://github.com/apache/hive/pull/1275#discussion_r458629144
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -149,17 +156,25 @@ public void run() {
String runAs = resolveUserToRunAs(tblNameOwners, t, p);
/* checkForCompaction includes many file metadata checks and may
be expensive.
* Therefore, using a thread pool here and running
checkForCompactions in parallel */
-
compactionList.add(CompletableFuture.runAsync(ThrowingRunnable.unchecked(() ->
- scheduleCompactionIfRequired(ci, t, p, runAs)),
compactionExecutor));
+ completionService.submit(() -> {
+ ThrowingRunnable.unchecked(() ->
scheduleCompactionIfRequired(ci, t, p, runAs));
+ return null;
Review comment:
what's the reasoning behind this change? returning some null doesn't add
more code readability
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
