pgaref commented on a change in pull request #1280:
URL: https://github.com/apache/hive/pull/1280#discussion_r458761137
##########
File path: storage-api/src/java/org/apache/hive/common/util/BloomKFilter.java
##########
@@ -36,7 +44,7 @@
*
* This implementation has much lesser L1 data cache misses than {@link
BloomFilter}.
Review comment:
I am afraid changing the logic of the implementation will also affect
the cache effectiveness/behaviour -- would it make sense to add a JMH test here
as well?
We could even save the bench-results in a log to keep track of whats
happening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
