belugabehr commented on a change in pull request #1290:
URL: https://github.com/apache/hive/pull/1290#discussion_r458813891
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java
##########
@@ -349,7 +350,7 @@ public boolean next() throws SQLException {
fetchedRows = RowSetFactory.create(results, protocol);
fetchedRowsItr = fetchedRows.iterator();
}
-
+
Review comment:
Please remove this superfluous whitespace
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java
##########
@@ -341,6 +341,7 @@ public boolean next() throws SQLException {
if (fetchedRows == null || !fetchedRowsItr.hasNext()) {
TFetchResultsReq fetchReq = new TFetchResultsReq(stmtHandle,
orientation, fetchSize);
+ LOG.debug(fetchReq.toString());
Review comment:
Take a look at this:
http://www.slf4j.org/faq.html#logging_performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
